Revert "Only add a canonical tag to the latest version of man pages" #1455
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 50063c7.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/canonical
branch
from
e98289f to
8fc9ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 50063c7.
What was the end-user problem that led to this PR?
The problem was that when you google
bundle check, the first result is https://bundler.io/v2.0/man/bundle-check.1.html. Instead, the first result would be ideally the man page for the latest version, not for a version no longer supported.What was your diagnosis of the problem?
My diagnosis was that we should tell google to consider the non versioned URL the canonical page for all versioned ones, so that it always prefer to list that page.
What is your fix for the problem, implemented in this PR?
My fix is to revert the commit where I stopped doing this. The rationale was that these pages are not identical to each other, but I think canonical is also appropriate for pages with similar content.
Why did you choose this fix out of the possible options?
I chose this fix because I'd like to see if has the desired effect.